ja4: Fix parsing of tshark --version
output
#165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cargo test
fails on CI:Analysis
The Rust
ja4
app parses the output oftshark --version
. The app expected the version number to be followed by a space, e.g."TShark (Wireshark) 4.4.0 (v4.4.0-0-g009a163470b5).\n"
. It failed on"TShark (Wireshark) 4.4.0.\n"
.Solution
Improve the parsing logic.