Add Option ROM warning to Usage section of the manpage #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text in the usage section did not mention that some firmware might need Microsoft certificates as well, so I copied pasted it from a section above. Some `$`s were also changed to `#`s to indicate that they should be run as root.
Foxboron
approved these changes
Apr 24, 2024
00-kat
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
00-kat
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
00-kat
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text in the usage section did not mention that some firmware might need Microsoft certificates as well, so I copied pasted it from line 48.
I noticed on a Reddit comment though that there's a warning if option ROM is detected, so this warning might be unnecessary. However, I also found issue #212, so I'm not sure if option ROM will always be reliably detected. Feel free to reject this PR if there is already a reliable warning when you have option ROM (I don't so I can't test).
I also did not include the
-mflag by default in thesbctl enroll-keys, since I was not sure how widespread OpROMs are.Some
$s were also changed to#s to indicate that they should be run as root (didn't want to make a separate PR for changing 7 characters). I'm not familiar with asciidoc, so hopefully#s don't have special meaning.