91-sbctl.install: Unconditionally remove file from database #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially undoes 5106d1e, but avoids that problem by ignoring non-zero exit statuses from `sbctl remove-file`. That commit stopped the script from failing when uninstalling a kernel where the UKI wasn't in sbctl's database. However, it causes the UKI to never be removed from the database if UKI removal is done by a script that runs before `91-sbctl.install`. This is the case with systemd-ukify's `60-ukify.install` and systemd's `90-uki-copy.install`. By the time that `91-sbctl.install` runs during kernel removal, `90-uki-copy.install` will have already deleted the UKI. Signed-off-by: Andrew Gunnerson <[email protected]>
Foxboron
approved these changes
Aug 1, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially undoes 5106d1e, but avoids that problem by ignoring non-zero exit statuses from
sbctl remove-file. That commit stopped the script from failing when uninstalling a kernel where the UKI wasn't in sbctl's database. However, it causes the UKI to never be removed from the database if UKI removal is done by a script that runs before91-sbctl.install.This is the case with systemd-ukify's
60-ukify.installand systemd's90-uki-copy.install. By the time that91-sbctl.installruns during kernel removal,90-uki-copy.installwill have already deleted the UKI.