Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the upstream v2.8.0 #18

Open
wants to merge 63 commits into
base: jalexander/v2.4.0
Choose a base branch
from

Conversation

jalexander
Copy link

This PR updates our stripity_stripe fork to v2.8.0. This is part of an effort to bring our forked version of the library closer to the latest upstream version of the library.

This matches all of the changes from upstream, except I added the properties back in that we are still using in massdriver.

Testing this locally by installing the commit ID from this PR.

snewcomer and others added 30 commits November 20, 2024 10:35
…ty#523)

We're already coercing the source to an id via the `cast_to_id` call,
this just makes the typespec match the implementation.

Closes beam-community#478
- fixes beam-community#519: Creating a card with cardholder as a cardholder struct throws
Update hackney to version 1.15.2 to work around Erlang/OTP 22.1 issue.
See benoitc/hackney#591
dnsbty and others added 24 commits November 20, 2024 12:18
This enables specifying that the payment is occurring non-interactively.

(https://stripe.com/docs/api/payment_intents/create)
payment_method_types is specified twice in the typespec, once required and once optional - the correct one is optional (per https://stripe.com/docs/api/payment_intents/create), so removed the required one.
The relationship[account_opener] field on a Person object has been renamed to relationship[representative].
On subscription schedules, invoice_settings, default_payment_method, billing_thresholds and collection_method are now nested under default_settings.
Deprecated tax information for Customers have been removed.
The deprecated tax_info and tax_info_verification fields on the Customer object are now removed in favor of tax_ids.
The deprecated tax_info parameter on the Customer create and update methods are removed in favor of tax_id_data.
For more information, view the migration guide.
As seen in this response to a call to Stripe.BankAccount.verify:

%Stripe.Error{
  code: :invalid_request_error,
  extra: %{
    card_code: :bank_account_verification_failed,
    http_status: 402,
    raw_error: %{
      "code" => "bank_account_verification_failed",
      "doc_url" => "https://stripe.com/docs/error-codes/bank-account-verification-failed",
      "message" => "The amounts provided do not match the amounts that were sent to the bank account.",
      "type" => "invalid_request_error"
    }
  },
  message: "The amounts provided do not match the amounts that were sent to the bank account.",
  request_id: nil,
  source: :stripe,
  user_message: nil
}
@jalexander jalexander requested a review from a team November 20, 2024 20:33
@jalexander jalexander changed the base branch from jalexander/v2.7.0 to jalexander/v2.4.0 November 20, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.