forked from beam-community/stripity-stripe
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the upstream v2.8.0 #18
Open
jalexander
wants to merge
63
commits into
jalexander/v2.4.0
Choose a base branch
from
jalexander/v2.8.0
base: jalexander/v2.4.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty#523) We're already coercing the source to an id via the `cast_to_id` call, this just makes the typespec match the implementation. Closes beam-community#478
- fixes beam-community#519: Creating a card with cardholder as a cardholder struct throws
Update hackney to version 1.15.2 to work around Erlang/OTP 22.1 issue. See benoitc/hackney#591
This enables specifying that the payment is occurring non-interactively. (https://stripe.com/docs/api/payment_intents/create)
payment_method_types is specified twice in the typespec, once required and once optional - the correct one is optional (per https://stripe.com/docs/api/payment_intents/create), so removed the required one.
The relationship[account_opener] field on a Person object has been renamed to relationship[representative].
On subscription schedules, invoice_settings, default_payment_method, billing_thresholds and collection_method are now nested under default_settings.
Deprecated tax information for Customers have been removed. The deprecated tax_info and tax_info_verification fields on the Customer object are now removed in favor of tax_ids. The deprecated tax_info parameter on the Customer create and update methods are removed in favor of tax_id_data. For more information, view the migration guide.
… API docs for version 2019-12-03
As seen in this response to a call to Stripe.BankAccount.verify: %Stripe.Error{ code: :invalid_request_error, extra: %{ card_code: :bank_account_verification_failed, http_status: 402, raw_error: %{ "code" => "bank_account_verification_failed", "doc_url" => "https://stripe.com/docs/error-codes/bank-account-verification-failed", "message" => "The amounts provided do not match the amounts that were sent to the bank account.", "type" => "invalid_request_error" } }, message: "The amounts provided do not match the amounts that were sent to the bank account.", request_id: nil, source: :stripe, user_message: nil }
…use with users protocols
This was referenced Nov 20, 2024
jalexander
changed the base branch from
jalexander/v2.7.0
to
jalexander/v2.4.0
November 20, 2024 21:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our stripity_stripe fork to v2.8.0. This is part of an effort to bring our forked version of the library closer to the latest upstream version of the library.
This matches all of the changes from upstream, except I added the properties back in that we are still using in massdriver.
Testing this locally by installing the commit ID from this PR.