Add start of support/testing with UP2500. #16
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it might be useful to open a pull request for discussion rather than spamming other people's issues :)
I've added parsing which I think works for all of for US2000/US3000/UP2500 as well as a few simple tests to make sure the code behaves as expected to help future refactoring.
I don't have a US2000/US3000 (or any multi battery configuration) to test with, so it someone could verify it works on real devices it would be helpful!
Again, many thanks for this code! It's great that I managed to talk to my battery with relatively little effort thanks to this :)