Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start of support/testing with UP2500. #16

Closed
wants to merge 2 commits into from

Conversation

abelsson
Copy link
Collaborator

@abelsson abelsson commented Sep 5, 2022

I thought it might be useful to open a pull request for discussion rather than spamming other people's issues :)

I've added parsing which I think works for all of for US2000/US3000/UP2500 as well as a few simple tests to make sure the code behaves as expected to help future refactoring.

I don't have a US2000/US3000 (or any multi battery configuration) to test with, so it someone could verify it works on real devices it would be helpful!

Again, many thanks for this code! It's great that I managed to talk to my battery with relatively little effort thanks to this :)

@abelsson
Copy link
Collaborator Author

abelsson commented Sep 5, 2022

I think this might fix the issues with mixing US3000 and US2000 mentioned in #2 and the US3000 problems mentioned in #4.

@Frankkkkk
Copy link
Owner

Merged via #17; thanks !

@Frankkkkk Frankkkkk closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants