-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Autoplay mode into mediaplayer #1181
Integrate Autoplay mode into mediaplayer #1181
Comments
Hi, I am looking to contribute , I have the development environment set up - how do I get started with possibly implementing this feature? For starters, I already set up a branch on my local end. |
@ubello64
Make it work somehow first (even partially working), think about the UI later? (Or make UI first then the actual function, the order is up to you) |
@PikachuEXE Ive noticed that the file "ft-video-player.js" contains references to some of the objects found inside the video player such as "playback speed". For example this snippet: createFullWindowButton: function () {
Am I on the right path in assuming that code I implement will follow a similar format to the code listed above? |
I guess so |
@PikachuEXE I have followed your suggestion to understand the behavior of 'up next', is this line : "return this.$store.getters.getPlayNextVideo" what causes 'autoplay'? |
|
@ubello64 can you post a snippet off the code we were messing with today? |
@shadycloud |
Hello, I noticed that in the video recommendations file there is a use of 'ft-toggle-switch' - can this toggle switch be used inside the video area window? I figured out the logic of attaching 'autoplay' functionality to a UI element, just need help figuring out what toggle switch can be used |
Hmm not sure what icon we should use for this because YT does this very clever with the toggle they use. It clearly indicates that autoplay is enables or paused like shown in the screenshot |
We'd need |
This seems helpful, https://www.tutorialspoint.com/adding-custom-video-js-control-bar-buttons |
Why it becomes a slider now |
Hi @ubello64, we are currently going to be suspending changes on the video player for the time being while we are working on a larger overhaul of the feature. Thank you for your help and enthusiasm, and please take a look at any other open issues that you would like to contribute to. Thank you! |
I support the enhancement of full-screen mode, especially in the context of integrating the Auto Play feature into the media player to improve user experience. However, there's a current issue where, in Auto Play mode, the full-screen mode is automatically exited when the next video starts, and this exit from full-screen mode is not properly detected. Addressing this issue would significantly improve the viewing experience. |
Is your feature request related to a usage problem (not a bug)? Please describe.
At this moment the Autoplay mode button is not part of the media player. Lets say for example u are in fullscreen but u want autoplay mode enabled then u need to do the following things:
Go out of fullscreen > enable autoplay > go into fullscreen.
That doesn't make allot of sense to me. This is also the case when u are in Fullwindow mode. I know that this feature doesnt really relate to the mediaplayer unlike the other functions but in my opinion this would enhance user experience.
Describe the solution you'd like to see implemented
Integrate the autoplay mode into the media player. See added screenshot for YT implementation.
Would be nice if the icon on the slider says play when enabled just like the one in the screenshot and pause when disabled.
When u hover the autoplay button and its off, it should say "Autoplay is off" and when its on it should say "Autoplay is on"
If that is done remove the autoplay button that is in the "Up Next" section.
Describe alternatives you've considered
None
Screenshots
Additional context
None
The text was updated successfully, but these errors were encountered: