Integrated autoplay button in video player #4335
Conversation
'spinner' icon is used as placeholder
Development
experimented with hue-rotate for spinner
shorcut added for autoplay
github-actions
bot
added
the
PR: waiting for review
src/renderer/videoJS.css
Outdated
|
|
||
| .video-js .vjs-play-control .vjs-icon-placeholder { | ||
| /* | ||
| .video-js .vjs-play-control .vjs-icon-placeholder {spinner |
There was a problem hiding this comment.
Was it crashing because of the added "spinner"?
There was a problem hiding this comment.
sorry just caught that extra reference to 'spinner' that shouldn't be there - FreeTube is now fine
Head branch was pushed to by a user without write access
|
I suggest you to use a different branch name next time |
|
Strange focus style (happens after click, not related to autoplay enable state) I could not tell from that button whether autoplay is enabled or not |
| } | ||
| .vjs-icon-spinner:before { | ||
| content: "\f10b"; | ||
| } | ||
| .vjs-button > .vjs-icon-spinner:before { | ||
| font-size: 1.66666666667em; |
There was a problem hiding this comment.
Minor indent issue but you should use an editor/update the editor you are using to read and enforce rules in https://github.com/FreeTubeApp/FreeTube/blob/development/.editorconfig file
See https://editorconfig.org
| font-size: 1.66666666667em; | |
| font-size: 1.66666666667em; |
|
Closing pull request - don't want to cause potential merge conflict. Feature also does not help end user determine whether or not if Auto play is on. Will open another pull request when the main issue is resolved |
Pull request was closed
github-actions
bot
removed
the
PR: waiting for review
Pull Request Type
Related issue
#1181
Description
Adds a button that toggles Auto Play when in player mode, shows shortcut on hover
Screenshots
Testing
Tested functionality in full window and regular to ensure next video played
Desktop
Ubuntu 22.04.3 LTS
FreeTube version: 0.19.1
Additional context
This line in videoJS.css caused FreeTube to crash today, unsure of why this is
