Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

118 Pascal_Triangle #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

118 Pascal_Triangle #37

wants to merge 2 commits into from

Conversation

JoannaCode
Copy link
Collaborator

FreeTymeKiyan
FreeTymeKiyan reviewed Mar 10, 2016
View reviewed changes
Easy/Pascal_Triangle.java Outdated
@@ -0,0 +1,57 @@
/*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not JavaDoc comment. Like I mentioned in the last PR, it starts with /** and ends with */, each row should have a * at it's beginning. It should be placed right above the class name. Please refer to my previous code here.

@FreeTymeKiyan
Copy link
Owner

Great to see that you actually use recursion to solve the problem. It's very good practice. But the code looks a bit messy. It would be much cleaner if you use loop instead.

@JoannaCode
Copy link
Collaborator Author

I programed in the leetcode first and copy to eclipse. The JavaDoc comment is from eclipse and the tab width is 4 in leetcode...

@FreeTymeKiyan
Copy link
Owner

@JoannaCode Then you probably need to format it using IDE before commit.

@JoannaCode
Copy link
Collaborator Author

OK. Let me try. I use JS instead of Java in work. So I am not familiar with Java format ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoannaCode @FreeTymeKiyan