Context autowiring | autoconfiguration #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
changed the title
pamil
reviewed
Jun 3, 2020
| @@ -63,6 +78,8 @@ public function configure(ArrayNodeDefinition $builder): void | |||
| ->scalarNode('class')->defaultNull()->end() | |||
| ->scalarNode('environment')->defaultNull()->end() | |||
| ->booleanNode('debug')->defaultNull()->end() | |||
| ->booleanNode('autoconfigure')->defaultFalse()->end() | |||
There was a problem hiding this comment.
I guess those options are not really related to the kernel configuration, so it should be on the same level with bootstrap and kernel options.
|
|
||
| private function handleAutoConfiguration(ContainerBuilder $container): void | ||
| { | ||
| $container->registerForAutoconfiguration(Context::class)->addTag(self::CONTEXT_TAG); |
There was a problem hiding this comment.
This probably won't work, since $container here is Behat's container, not the application's container with all the context services. There's a bundle inside this extension where it is already implemented.
|
@Guikingone Hello, let me know if there is an inspiration to continue your work.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is opened in order to ease the discussions about the implementation, this is a work in progress 🙂