fix!: change semantic markup

BREAKING CHANGE: Change markup to improve SEO
FriendsOfFlarum · Apr 5, 2024 · 91939bb · 91939bb
1 parent 2ecda05
commit 91939bb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/js/src/forum/components/Poll/PollTitle.tsx b/js/src/forum/components/Poll/PollTitle.tsx
@@ -15,7 +15,7 @@ export default class PollTitle extends Component<PollTitleAttrs> {
   pollTitleItems(): ItemList<Mithril.Children> {
     const items = new ItemList<Mithril.Children>();
 
-    items.add('title', <h2 className="Poll-title">{this.attrs.poll.question()}</h2>);
+    items.add('title', <h3 className="Poll-title">{this.attrs.poll.question()}</h3>);
 
     return items;
   }

diff --git a/js/src/forum/components/PollShowcase.tsx b/js/src/forum/components/PollShowcase.tsx
@@ -20,13 +20,13 @@ export default class PollShowcase extends Component<PollListAttrs, PollListState
   view(): Mithril.Children {
     return (
       <div className="PollShowcase">
-        <div className="PollShowcase-featured">
-          <h3>{app.translator.trans('fof-polls.forum.showcase.active-polls')}</h3>
+        <div className="PollShowcase--active">
+          <h2 className="PollShowcase-title PollShowcase-title--active">{app.translator.trans('fof-polls.forum.showcase.active-polls')}</h2>
           {this.showcaseItems().toArray()}
           {this.showcaseItems().toArray().length === 0 && <Placeholder text={app.translator.trans('fof-polls.forum.showcase.no-active-polls')} />}
         </div>
-        <div className="PollShowcase-ended">
-          <h3>{app.translator.trans('fof-polls.forum.showcase.ended-polls')}</h3>
+        <div className="PollShowcase--ended">
+          <h2 className="PollShowcase-title PollShowcase-title--ended">{app.translator.trans('fof-polls.forum.showcase.ended-polls')}</h2>
           {this.endedItems().toArray()}
           {this.endedItems().toArray().length === 0 && <Placeholder text={app.translator.trans('fof-polls.forum.showcase.no-recent-polls')} />}
         </div>