-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CVE-2024-4990 #724
Merged
Merged
Add CVE-2024-4990 #724
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| title: Unsafe Reflection in base Component class | ||
| link: https://github.com/yiisoft/yii2/security/advisories/GHSA-cjcc-p67m-7qxm | ||
| cve: CVE-2024-4990 | ||
| branches: | ||
| 2.0.49.x: | ||
| time: null | ||
| versions: ['<=2.0.49'] | ||
DBX12 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| reference: composer://yiisoft/yii2 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood the
timefield correctly, that should hold the timestamp of the commit which fixed it in that branch. So if it is not for that branch, then I would go with 2024-05-30 since that was the commit yiisoft/yii2@628d406 which fixed it in the2.0.50branch. If that field is understood as fixed in that branch I would rather use 2024-06-04 16:23:00 from yiisoft/yii2@62d081f since that was merged to branch2.0.49.x.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DBX12 makes sense, can you apply that change then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @naderman
can you clarify how the
timefield is to be understood? :)Edit: I misread your comment, so you can disregard that question. Also, the related CVE got updated again so I've pushed an update.