Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phpdoc on Table::findOneBy(...) to include false in @return #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update phpdoc on Table::findOneBy(...) to include false in @return #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Doctrine/Table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1725,7 +1725,7 @@ public function findBy($fieldName, $value, $hydrationMode = null)
* @param string $column field for the WHERE clause
* @param string|array $value prepared statement parameter
* @param int $hydrationMode Doctrine_Core::HYDRATE_ARRAY or Doctrine_Core::HYDRATE_RECORD
* @return Doctrine_Record
* @return Doctrine_Record|false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Query::fetchOne() the return could be array|Doctrine_Record|false: those whould be added too, wdyt?

At the same time, the implementation of Query::fetchOne() has:

        if (is_scalar($collection)) {
            return $collection;
        }

Which then, could return a scalar too int|bool|float

*/
public function findOneBy($fieldName, $value, $hydrationMode = null)
{
Expand Down
Loading