[BUGFIX] Fix type of MM_oppositeUsage

FriendsOfTYPO3 · Dec 9, 2024 · fd7b6ff · fd7b6ff
1 parent c597601
commit fd7b6ff
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/Classes/FieldType/RelationFieldType.php b/Classes/FieldType/RelationFieldType.php
@@ -37,7 +37,7 @@ final class RelationFieldType extends AbstractFieldType
     private string $MM = '';
     private string $MM_opposite_field = '';
     private array $MM_match_fields = [];
-    private string $MM_oppositeUsage = '';
+    private array $MM_oppositeUsage = [];
     private string $MM_table_where = '';
     private string $dontRemapTablesOnCopy = '';
     private bool $localizeReferencesAtParentLocalization = false;
@@ -70,7 +70,7 @@ public function createFromArray(array $settings): RelationFieldType
         $self->MM = (string)($settings['MM'] ?? $self->MM);
         $self->MM_opposite_field = (string)($settings['MM_opposite_field'] ?? $self->MM_opposite_field);
         $self->MM_match_fields = (array)($settings['MM_match_fields'] ?? $self->MM_match_fields);
-        $self->MM_oppositeUsage = (string)($settings['MM_oppositeUsage'] ?? $self->MM_oppositeUsage);
+        $self->MM_oppositeUsage = (array)($settings['MM_oppositeUsage'] ?? $self->MM_oppositeUsage);
         $self->MM_table_where = (string)($settings['MM_table_where'] ?? $self->MM_table_where);
         $self->dontRemapTablesOnCopy = (string)($settings['dontRemapTablesOnCopy'] ?? $self->dontRemapTablesOnCopy);
         $self->localizeReferencesAtParentLocalization = (bool)($settings['localizeReferencesAtParentLocalization'] ?? $self->localizeReferencesAtParentLocalization);
@@ -127,7 +127,7 @@ public function getTca(): array
         if ($this->MM_match_fields !== []) {
             $config['MM_match_fields'] = $this->MM_match_fields;
         }
-        if ($this->MM_oppositeUsage !== '') {
+        if ($this->MM_oppositeUsage !== []) {
             $config['MM_oppositeUsage'] = $this->MM_oppositeUsage;
         }
         if ($this->MM_table_where !== '') {

diff --git a/Classes/FieldType/SelectFieldType.php b/Classes/FieldType/SelectFieldType.php
@@ -32,7 +32,7 @@ final class SelectFieldType extends AbstractFieldType
     private string $MM = '';
     private string $MM_opposite_field = '';
     private array $MM_match_fields = [];
-    private string $MM_oppositeUsage = '';
+    private array $MM_oppositeUsage = [];
     private string $MM_table_where = '';
     private string $dontRemapTablesOnCopy = '';
     private bool $localizeReferencesAtParentLocalization = false;
@@ -72,7 +72,7 @@ public function createFromArray(array $settings): SelectFieldType
         $self->MM = (string)($settings['MM'] ?? $self->MM);
         $self->MM_opposite_field = (string)($settings['MM_opposite_field'] ?? $self->MM_opposite_field);
         $self->MM_match_fields = (array)($settings['MM_match_fields'] ?? $self->MM_match_fields);
-        $self->MM_oppositeUsage = (string)($settings['MM_oppositeUsage'] ?? $self->MM_oppositeUsage);
+        $self->MM_oppositeUsage = (array)($settings['MM_oppositeUsage'] ?? $self->MM_oppositeUsage);
         $self->MM_table_where = (string)($settings['MM_table_where'] ?? $self->MM_table_where);
         $self->dontRemapTablesOnCopy = (string)($settings['dontRemapTablesOnCopy'] ?? $self->dontRemapTablesOnCopy);
         $self->localizeReferencesAtParentLocalization = (bool)($settings['localizeReferencesAtParentLocalization'] ?? $self->localizeReferencesAtParentLocalization);
@@ -128,7 +128,7 @@ public function getTca(): array
         if ($this->MM_match_fields !== []) {
             $config['MM_match_fields'] = $this->MM_match_fields;
         }
-        if ($this->MM_oppositeUsage !== '') {
+        if ($this->MM_oppositeUsage !== []) {
             $config['MM_oppositeUsage'] = $this->MM_oppositeUsage;
         }
         if ($this->MM_table_where !== '') {

diff --git a/Tests/Unit/FieldTypes/RelationFieldTypeTest.php b/Tests/Unit/FieldTypes/RelationFieldTypeTest.php
@@ -61,7 +61,7 @@ public static function getTcaReturnsExpectedTcaDataProvider(): iterable
                 'MM_match_fields' => [
                     'foo' => 'bar',
                 ],
-                'MM_oppositeUsage' => 'foo',
+                'MM_oppositeUsage' => ['foo'],
                 'MM_table_where' => 'foo',
                 'dontRemapTablesOnCopy' => 'foo',
                 'localizeReferencesAtParentLocalization' => 1,
@@ -117,7 +117,7 @@ public static function getTcaReturnsExpectedTcaDataProvider(): iterable
                     'MM_match_fields' => [
                         'foo' => 'bar',
                     ],
-                    'MM_oppositeUsage' => 'foo',
+                    'MM_oppositeUsage' => ['foo'],
                     'MM_table_where' => 'foo',
                     'dontRemapTablesOnCopy' => 'foo',
                     'localizeReferencesAtParentLocalization' => true,
@@ -163,7 +163,7 @@ public static function getTcaReturnsExpectedTcaDataProvider(): iterable
                 'MM' => '',
                 'MM_opposite_field' => '',
                 'MM_match_fields' => [],
-                'MM_oppositeUsage' => '',
+                'MM_oppositeUsage' => [],
                 'MM_table_where' => '',
                 'dontRemapTablesOnCopy' => '',
                 'localizeReferencesAtParentLocalization' => 0,

diff --git a/Tests/Unit/FieldTypes/SelectFieldTypeTest.php b/Tests/Unit/FieldTypes/SelectFieldTypeTest.php
@@ -47,7 +47,7 @@ public static function getTcaReturnsExpectedTcaDataProvider(): iterable
                 'MM_match_fields' => [
                     'foo' => 'bar',
                 ],
-                'MM_oppositeUsage' => 'foo',
+                'MM_oppositeUsage' => ['foo'],
                 'MM_table_where' => 'foo',
                 'dontRemapTablesOnCopy' => 'foo',
                 'localizeReferencesAtParentLocalization' => 1,
@@ -105,7 +105,7 @@ public static function getTcaReturnsExpectedTcaDataProvider(): iterable
                     'MM_match_fields' => [
                         'foo' => 'bar',
                     ],
-                    'MM_oppositeUsage' => 'foo',
+                    'MM_oppositeUsage' => ['foo'],
                     'MM_table_where' => 'foo',
                     'dontRemapTablesOnCopy' => 'foo',
                     'localizeReferencesAtParentLocalization' => true,
@@ -162,7 +162,7 @@ public static function getTcaReturnsExpectedTcaDataProvider(): iterable
                 'MM' => '',
                 'MM_opposite_field' => '',
                 'MM_match_fields' => [],
-                'MM_oppositeUsage' => '',
+                'MM_oppositeUsage' => [],
                 'MM_table_where' => '',
                 'dontRemapTablesOnCopy' => '',
                 'localizeReferencesAtParentLocalization' => 0,