Remove explicit casting

At least the ugly casting is gone... Looks like other parts of zinc also relys on pattern matching instead of java style casting.
Friendseeker · Jan 2, 2024 · e7cb256 · e7cb256
1 parent cd376cb
commit e7cb256
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/internal/compiler-bridge/src/main/scala/xsbt/CallbackGlobal.scala b/internal/compiler-bridge/src/main/scala/xsbt/CallbackGlobal.scala
@@ -11,12 +11,12 @@
 
 package xsbt
 
-import xsbti.{ AnalysisCallback, AnalysisCallback3, PathBasedFile, Severity }
+import xsbti.{AnalysisCallback, AnalysisCallback3, PathBasedFile, Severity, VirtualFileWrite}
 import xsbti.compile._
 
 import scala.tools.nsc._
 import io.AbstractFile
-import java.nio.file.{ Files, Path }
+import java.nio.file.{Files, Path}
 import scala.reflect.io.PlainFile
 import scala.reflect.ReflectAccess._
 import scala.reflect.internal.util.BatchSourceFile
@@ -79,10 +79,13 @@ sealed class ZincCompiler(settings: Settings, dreporter: DelegatingReporter, out
     with ZincGlobalCompat {
 
   override def getSourceFile(f: AbstractFile): BatchSourceFile = {
-    val file = f match {
-      case plainFile: PlainFile =>
-        val vf = callback.asInstanceOf[AnalysisCallback3].toVirtualFile(plainFile.file.toPath)
-        new ZincPlainFile(vf.asInstanceOf[PathBasedFile])
+    val file = (f, callback) match {
+      case (plainFile: PlainFile, callback3: AnalysisCallback3) =>
+        val virtualFile = callback3.toVirtualFile(plainFile.file.toPath)
+        virtualFile match {
+          case underlying: PathBasedFile => new ZincPlainFile(underlying)
+          case _ => f
+        }
       case _ => f
     }
     super.getSourceFile(file)