Skip to content

Commit

Permalink
feat: add confirm dialog when saving/cancelling
Browse files Browse the repository at this point in the history
  • Loading branch information
@FriesI23
FriesI23 committed Jan 31, 2025
1 parent 20314a7 commit f9eae57
Show file tree
Hide file tree
Showing 4 changed files with 99 additions and 27 deletions.
9 changes: 9 additions & 0 deletions lib/provider/app_sync_server_form.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ class AppSyncServerFormViewModel extends ChangeNotifier

bool _mounted = true;
bool _pwdLoaded = false;
bool _edited = false;
AppSyncViewModel? _parent;
Completer<(String, String?)>? _pwdCompleter;

Expand All @@ -56,11 +57,19 @@ class AppSyncServerFormViewModel extends ChangeNotifier
_mounted = false;
}

@override
void notifyListeners() {
_edited = true;
super.notifyListeners();
}

@override
bool get mounted => _mounted;

bool get pwdLoaded => _pwdLoaded;

bool get edited => _edited;

bool get canSave => switch (type) {
AppSyncServerType.webdav => pathInputController.text.isNotEmpty,
_ => true,
Expand Down
2 changes: 2 additions & 0 deletions lib/view/for_app_sync_server_editor/app_sync_server_password.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ class _AppSyncServerPasswordField extends State<AppSyncServerPasswordField> {
keyboardType: TextInputType.visiblePassword,
focusNode: _focusNode,
enabled: widget.enabled,
onChanged: (_) =>
context.read<AppSyncServerFormViewModel>().refreshCanSaveStatus(),
),
);
}
Expand Down
2 changes: 2 additions & 0 deletions lib/view/for_app_sync_server_editor/app_sync_server_username.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ class AppSyncServerUsernameTile extends StatelessWidget {
hintText: 'Enter username here, leave empty if not required.',
),
keyboardType: TextInputType.text,
onChanged: (_) =>
context.read<AppSyncServerFormViewModel>().refreshCanSaveStatus(),
),
),
);
Expand Down
113 changes: 86 additions & 27 deletions lib/view/page_app_sync_server_editor.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import '../common/consts.dart';
import '../component/widget.dart';
import '../model/app_sync_server.dart';
import '../provider/app_sync_server_form.dart';
import 'common/_dialog.dart';
import 'common/_widget.dart';
import 'common/app_ui_layout_builder.dart';
import 'for_app_sync_server_editor/_widget.dart';
Expand All @@ -31,6 +32,7 @@ Future<AppSyncServerForm?> naviToAppSyncServerEditorDialog({
}) async {
return showDialog<AppSyncServerForm>(
context: context,
barrierDismissible: false,
builder: (context) => PageAppSyncServerEditor(
serverConfig: serverConfig,
showInFullscreenDialog: naviWithFullscreenDialog,
Expand Down Expand Up @@ -90,52 +92,105 @@ class _AppSyncServerEditerView extends State<AppSyncServerEditorView> {
showAdvanceConfig = false;
}

void _onSaveButtonPressed() {
// TODO(Sync): need confim dialog
void _onSaveButtonPressed() async {
final bool confirmed;
final vm = context.read<AppSyncServerFormViewModel>();
assert(vm.canSave, "Can't save current config, got ${vm.formSnapshot}");
Navigator.of(context).pop(vm.getFinalForm());
final form = vm.getFinalForm();
if (vm.edited && vm.crtServerConfig != null) {
confirmed = await showConfirmDialog(
context: context,
title: const Text("Confirm Save Changes"),
subtitle: const Text(
"Saving will overwrite previous server configuration."),
cancelText: const Text("cancel"),
confirmText: const Text("confirm"),
) ??
false;
} else {
confirmed = true;
}
if (!mounted || !confirmed) return;
Navigator.of(context).pop(form);
}

bool shouldShowCancelConfirmDialog(AppSyncServerFormViewModel vm) =>
vm.edited;

Future<void> cancelConfirmProcess([AppSyncServerForm? result]) async {
final bool confirmed;
final vm = context.read<AppSyncServerFormViewModel>();
if (shouldShowCancelConfirmDialog(vm)) {
confirmed = await showConfirmDialog(
context: context,
title: const Text("Unsaved Changes"),
subtitle: const Text("Exiting will discard all unsaved changes."),
cancelText: const Text("cancel"),
confirmText: const Text("exit"),
) ??
false;
} else {
confirmed = true;
}
if (!mounted || !confirmed) return;
Navigator.maybeOf(context)?.pop(result);
}

void _onCancelButtonPressed() => cancelConfirmProcess();

void _onAdvanceConfigExpansionChanged(bool value) =>
showAdvanceConfig = value;

@override
Widget build(BuildContext context) {
return AnimatedSwitcher(
transitionBuilder: (child, animation) =>
FadeTransition(opacity: animation, child: child),
duration: const Duration(milliseconds: 300),
child: widget.showInFullscreenDialog
? _AppSyncServerEditorFsDialog(
key: const ValueKey("fullscreen"),
serverConfig: widget.serverConfig,
onSaveButtonPressed: _onSaveButtonPressed,
showAdvanceConfig: showAdvanceConfig,
onAdvConfigExpansionChanged: _onAdvanceConfigExpansionChanged,
)
: _AppSyncServerEditorDialog(
key: const ValueKey("dialog"),
serverConfig: widget.serverConfig,
onSaveButtonPressed: _onSaveButtonPressed,
showAdvanceConfig: showAdvanceConfig,
onAdvConfigExpansionChanged: _onAdvanceConfigExpansionChanged,
),
);
}
Widget build(BuildContext context) =>
Selector<AppSyncServerFormViewModel, bool>(
selector: (context, vm) => shouldShowCancelConfirmDialog(vm),
builder: (context, value, child) => PopScope<AppSyncServerForm>(
canPop: !value,
child: child!,
onPopInvokedWithResult: (didPop, result) async {
if (didPop) return;
await cancelConfirmProcess(result);
},
),
child: AnimatedSwitcher(
transitionBuilder: (child, animation) =>
FadeTransition(opacity: animation, child: child),
duration: const Duration(milliseconds: 300),
child: widget.showInFullscreenDialog
? _AppSyncServerEditorFsDialog(
key: const ValueKey("fullscreen"),
serverConfig: widget.serverConfig,
onSaveButtonPressed: _onSaveButtonPressed,
onCancelButtonPressed: _onCancelButtonPressed,
showAdvanceConfig: showAdvanceConfig,
onAdvConfigExpansionChanged: _onAdvanceConfigExpansionChanged,
)
: _AppSyncServerEditorDialog(
key: const ValueKey("dialog"),
serverConfig: widget.serverConfig,
onSaveButtonPressed: _onSaveButtonPressed,
onCancelButtonPressed: _onCancelButtonPressed,
showAdvanceConfig: showAdvanceConfig,
onAdvConfigExpansionChanged: _onAdvanceConfigExpansionChanged,
),
),
);
}

class _AppSyncServerEditorFsDialog extends StatelessWidget {
final AppSyncServer? serverConfig;
final bool showAdvanceConfig;
final VoidCallback? onSaveButtonPressed;
final VoidCallback? onCancelButtonPressed;
final ValueChanged<bool>? onAdvConfigExpansionChanged;

const _AppSyncServerEditorFsDialog({
super.key,
required this.serverConfig,
required this.showAdvanceConfig,
required this.onSaveButtonPressed,
required this.onCancelButtonPressed,
this.onAdvConfigExpansionChanged,
});

Expand All @@ -144,7 +199,9 @@ class _AppSyncServerEditorFsDialog extends StatelessWidget {
child: ColorfulNavibar(
child: Scaffold(
appBar: AppBar(
leading: const PageBackButton(reason: PageBackReason.close),
leading: PageBackButton(
reason: PageBackReason.close,
onPressed: onCancelButtonPressed),
actions: [
AppSyncServerSaveButton(onPressed: onSaveButtonPressed),
],
Expand Down Expand Up @@ -174,13 +231,15 @@ class _AppSyncServerEditorDialog extends StatelessWidget {
final AppSyncServer? serverConfig;
final bool showAdvanceConfig;
final VoidCallback? onSaveButtonPressed;
final VoidCallback? onCancelButtonPressed;
final ValueChanged<bool>? onAdvConfigExpansionChanged;

const _AppSyncServerEditorDialog({
super.key,
required this.serverConfig,
required this.showAdvanceConfig,
required this.onSaveButtonPressed,
required this.onCancelButtonPressed,
this.onAdvConfigExpansionChanged,
});

Expand Down Expand Up @@ -227,7 +286,7 @@ class _AppSyncServerEditorDialog extends StatelessWidget {
),
actions: [
TextButton(
onPressed: Navigator.of(context).pop,
onPressed: onCancelButtonPressed,
child: Text("cancel"),
),
AppSyncServerSaveButton(onPressed: onSaveButtonPressed),
Expand Down

0 comments on commit f9eae57

Please sign in to comment.