Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS filters performances plot #144

Merged
merged 5 commits into from
Aug 3, 2024
Merged

IS filters performances plot #144

merged 5 commits into from
Aug 3, 2024

Conversation

Frix-x
Copy link
Owner

@Frix-x Frix-x commented Jul 16, 2024

WIP

Summary by Sourcery

This pull request enhances the input shaper calibration tool by adding new plotting features for maximum vibrations and smoothing tests. It also refactors the calibration process for better compatibility and improves the overall layout and information display in the plots. Additionally, the ShakeTune initialization and command registration processes have been streamlined and improved.

  • New Features:
    • Introduced new constants for plotting maximum vibrations and smoothing tests in the shaper graph creator.
    • Added functionality to compute and plot smoothing values for input shaper filters.
    • Implemented a new plot for smoothing vs acceleration in the shaper calibration tool.
    • Enhanced the shaper calibration tool to include a table of shaper data and recommendations.
  • Enhancements:
    • Refactored the shaper calibration process to handle compatibility with older versions of Klipper.
    • Improved the layout and information display in the shaper calibration plots.
    • Updated the ShakeTune initialization to include default configuration values and better error handling.
    • Refactored the registration of ShakeTune commands to streamline the process and improve code readability.

Copy link

sourcery-ai bot commented Jul 16, 2024

Reviewer's Guide by Sourcery

This pull request introduces several enhancements and refactors to the ShakeTune module, focusing on improving the performance plots for input shaper filters. Key changes include the addition of new constants, refactoring of the calibrate_shaper and plot_freq_response functions, and the introduction of new plotting functions. Additionally, the ShakeTune class has been refactored to improve configuration handling and command registration.

File-Level Changes

Files Changes
shaketune/graph_creators/shaper_graph_creator.py
shaketune/shaketune.py
Refactored the ShakeTune module to improve configuration handling, command registration, and performance plotting for input shaper filters.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@Frix-x Frix-x changed the base branch from main to develop July 16, 2024 22:47
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Frix-x - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 7 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

shaketune/shaketune.py Show resolved Hide resolved
shaketune/shaketune.py Show resolved Hide resolved
shaketune/shaketune.py Show resolved Hide resolved
@Frix-x Frix-x merged commit 064150b into develop Aug 3, 2024
3 checks passed
@Frix-x Frix-x deleted the smooth-accel branch August 3, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant