-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to fix Klipper TTC errors #168
Conversation
to avoid having multiple CSV files open at once and accelerometer measurements on-going at the same time
with all the logic to load them back and reconstruct the .stdata file
with all the logic to load them back and reconstruct the .stdata file
Adding the chunk size as a shaketune parameter
Reviewer's Guide by SourceryThis pull request introduces significant changes to the Shake&Tune project, primarily focusing on improving data handling, storage, and processing of accelerometer measurements. The changes include a new .stdata file format for storing measurements, a chunking mechanism for handling multiple measurements, and various optimizations in how accelerometer data is written to disk and retrieved from Klipper internal objects. Sequence diagram for accelerometer data recordingsequenceDiagram
participant User
participant Accelerometer
participant MeasurementsManager
participant Klipper
User->>Accelerometer: start_recording(measurements_manager, name, append_time)
Accelerometer->>MeasurementsManager: add_measurement(name)
User->>Accelerometer: stop_recording()
Accelerometer->>Klipper: finish_measurements()
Klipper-->>Accelerometer: samples
Accelerometer->>MeasurementsManager: append_samples_to_last_measurement(samples)
User->>Accelerometer: wait_for_samples(timeout)
Accelerometer-->>User: samples_ready
ER diagram for .stdata file formaterDiagram
MEASUREMENT {
string name
SamplesList samples
}
SAMPLES_LIST {
float time
float accel_x
float accel_y
float accel_z
}
MEASUREMENT ||--o{ SAMPLES_LIST : contains
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Frix-x - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR adds:
Summary by Sourcery
Add support for .stdata files to store accelerometer measurements and implement a chunking mechanism to handle multiple measurements efficiently. Update documentation to reflect these changes and provide guidance on new configuration options.
New Features:
Enhancements:
Documentation: