Skip to content

Commit

Permalink
Update Bicep modules and main.bicep parameters
Browse files Browse the repository at this point in the history
Updated BeyondTrustConnector.sln to include new Bicep module files:
- Added modules/datacollection.bicep
- Added modules/functionapp.bicep
- Added modules/vault-role-assignment.bicep
- Added modules/workspace-role-assignment.bicep

Modified functionappModule in main.bicep:
- Updated appName parameter for uniqueness
- Changed workspaceName parameter in dataCollection object

Updated workspaceMetricPublisherRoleAssignment module:
- Removed comment from roleDefinitionId parameter
  • Loading branch information
FrodeHus committed Dec 16, 2024
1 parent ca118f5 commit b6d579b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions BeyondTrustConnector.sln
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "BeyondTrustConnector.Tests"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "deploy", "deploy", "{F48F5888-80FE-41FD-B8EE-965E758D2DB3}"
ProjectSection(SolutionItems) = preProject
modules\datacollection.bicep = modules\datacollection.bicep
modules\functionapp.bicep = modules\functionapp.bicep
main.bicep = main.bicep
modules\vault-role-assignment.bicep = modules\vault-role-assignment.bicep
modules\workspace-role-assignment.bicep = modules\workspace-role-assignment.bicep
EndProjectSection
EndProject
Global
Expand Down
6 changes: 3 additions & 3 deletions main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ module datacollectionModule './modules/datacollection.bicep' = {
module functionappModule './modules/functionapp.bicep' = {
name: 'functionapp'
params: {
appName: functionConfig.name
appName: '${functionConfig.name}-${uniqueString(resourceGroup().name)}'
location: resourceGroup().location
dataCollection: {
workspaceName: datacollectionModule.outputs.workspaceResourceId
workspaceName: datacollectionModule.outputs.workspaceId
endpointImmutableId: datacollectionModule.outputs.dcrImmutableId
endpointUri: datacollectionModule.outputs.logsIngestionEndpoint
beyondTrustTenant: beyondTrustTenant
Expand Down Expand Up @@ -62,7 +62,7 @@ module workspaceMetricPublisherRoleAssignment './modules/workspace-role-assignme
name: 'workspaceMetricPublisherRoleAssignment'
params: {
roleAssignmentName: '${uniqueString(functionConfig.name)}-workspace-metric-publisher-role-assignment'
roleDefinitionId: '3913510d-42f4-4e42-8a64-420c390055eb' // Log Analytics Reader
roleDefinitionId: '3913510d-42f4-4e42-8a64-420c390055eb'
principalId: principalId
workspaceName: datacollection.workspaceName
}
Expand Down

0 comments on commit b6d579b

Please sign in to comment.