Refactor and optimize AccessSessionUpdater and related methods #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored AccessSessionUpdater to include Azure Function attributes and optimized session ID retrieval. Improved readability and efficiency of GetUserDetails and streamlined XML parsing logic. Added optional offsetSeconds parameter to GetLastUpdatedTime. Removed unnecessary timestamp adjustment in BeyondTrustService.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and optimize AccessSessionUpdater and related methods
Refactored AccessSessionUpdater to include Azure Function attributes
and optimized session ID retrieval. Improved readability and efficiency
of GetUserDetails and streamlined XML parsing logic. Added optional
offsetSeconds parameter to GetLastUpdatedTime. Removed unnecessary
timestamp adjustment in BeyondTrustService.
PR Classification
Code cleanup and feature enhancement to improve readability, efficiency, and accuracy of session updates.
PR Summary
Refactored
AccessSessionUpdaterto run as an Azure Function with improved session processing and user detail extraction.AccessSessionUpdater: AddedFunctionattribute andTimerTriggerto run every 15 minutes; optimizedRunmethod to check for existing sessions.GetUserDetails: Streamlined XML user detail extraction for better readability.GetLastUpdatedTime: AddedoffsetSecondsparameter to ensure no events are missed.BeyondTrustService: AdjustedunixTimecalculation to align start time accurately with the report period.