refactor: refactor ContentRow into a record in place of a class #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmoschini
commented
Jan 26, 2022
| @@ -24,7 +24,7 @@ public async Task<ContentModel> GetCampaignModel(string accountName, int campaig | |||
| JOIN [User] u ON u.IdUser = ca.IdUser | |||
| WHERE co.IdCampaign = @campaignId AND u.Email = @accountName AND co.EditorType = 5"; | |||
| var result = await connection.QueryFirstOrDefaultAsync<ContentRow>(databaseQuery, new { campaignId, accountName }); | |||
There was a problem hiding this comment.
Ooops, I am not sure if it will work: DapperLib/Dapper#1571
@maurocardinali let me know when you be testing your changes and we could test it too.
andresmoschini
force-pushed
the
content-row
branch
from
7d05d40 to
8fa1d69
Compare
|
We test it with @maurocardinali and effectively it does not works fine with Dapper (see DapperLib/Dapper#1571) Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor change to keep the code style aligned with #21.
It will force us to define all properties and make the object read-only. Record types are really convenient for this class of DTOs.