Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Textarea): update defaultValue and value props logic and stories #1680

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

ryancarville
Copy link
Contributor

defaultValue and value props were not being properly set. This updates the usage and logic of these two props and the stories to use them properly.

@ryancarville ryancarville self-assigned this Dec 14, 2023
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for beta-fondue-components ready!

Name Link
🔨 Latest commit 0d50e1a
🔍 Latest deploy log https://app.netlify.com/sites/beta-fondue-components/deploys/657b16c23301fe000890ea6a
😎 Deploy Preview https://deploy-preview-1680--beta-fondue-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ryancarville ryancarville added the bug Something isn't working label Dec 14, 2023
@ryancarville ryancarville marked this pull request as ready for review December 14, 2023 10:32
@ryancarville ryancarville changed the title fix(Textarea): update defaultValue and value props logic, styles and … fix(Textarea): update defaultValue and value props logic and stories Dec 14, 2023
@ryancarville ryancarville merged commit 72c8790 into beta Dec 14, 2023
15 checks passed
@ryancarville ryancarville deleted the fix/teaxtarea-bugs branch December 14, 2023 15:55
Copy link
Contributor

Lead time: 5 hours, 25 minutes, 29 seconds (5.42 total hours) from first commit to close.
Review time: 5 hours, 23 minutes, 1 seconds (5.38 total hours) from ready for review to close.

  • First commit: 14.12.2023, 11:29:46.
  • Ready for review: 14.12.2023, 11:32:14.
  • Closed: 14.12.2023, 16:55:15.

Copy link
Contributor

🎉 This PR is included in version 12.0.0-beta.392 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants