Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dropdown migration guide #1998

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

jose-costa-frontify
Copy link
Contributor

@jose-costa-frontify jose-costa-frontify commented Aug 8, 2024

CU-8695bwruq

@jose-costa-frontify jose-costa-frontify requested a review from a team as a code owner August 8, 2024 13:03
Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 455df11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@frontify/fondue-components Patch
@frontify/fondue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 8, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-09 09:00 UTC

@frontify-clickup-bot
Copy link
Collaborator

@@ -246,7 +249,6 @@ Changes:

```tsx
const [isOpen, setIsOpen] = useState(false);

Copy link
Member

@SamuelAlev SamuelAlev Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line break can be added back, else it looks compact on the UI

@SamuelAlev SamuelAlev merged commit 285115d into main Aug 9, 2024
15 checks passed
@SamuelAlev SamuelAlev deleted the feat/add-dropdown-migration-guide branch August 9, 2024 09:00
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Lead time: 22 hours, 47 minutes, 33 seconds (22.79 total hours) from first commit to close.
Review time: 19 hours, 56 minutes, 39 seconds (19.94 total hours) from ready for review to close.

  • First commit: 8.8.2024, 12:12:31.
  • Ready for review: 8.8.2024, 15:03:25.
  • Closed: 9.8.2024, 11:00:04.

@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants