Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Flyout): margin top is overriden #2013

Closed
wants to merge 2 commits into from
Closed

Conversation

fulopdaniel
Copy link
Contributor

I was trying to fix this issue in https://github.com/Frontify/web-app/pull/5078 which got reverted, so this is the other approach.

@fulopdaniel fulopdaniel requested a review from a team as a code owner August 16, 2024 08:19
Copy link

changeset-bot bot commented Aug 16, 2024

🦋 Changeset detected

Latest commit: c4e5704

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@frontify/fondue-components Patch
@frontify/fondue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 16, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-16 13:02 UTC

@SamuelAlev
Copy link
Member

Will be fixed in #2015, can I close the PR?

@fulopdaniel
Copy link
Contributor Author

Will be fixed in #2015, can I close the PR?

great, thanks! Closed.

Copy link
Contributor

Lead time: 4 hours, 43 minutes, 24 seconds (4.72 total hours) from first commit to close.
Review time: 4 hours, 42 minutes, 34 seconds (4.71 total hours) from ready for review to close.

  • First commit: 16.8.2024, 10:19:04.
  • Ready for review: 16.8.2024, 10:19:54.
  • Closed: 16.8.2024, 15:02:28.

@SamuelAlev SamuelAlev deleted the fix/flyout-top-margin branch August 16, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants