Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scroll area component #2034

Merged
merged 16 commits into from
Sep 5, 2024
Merged

Conversation

jose-costa-frontify
Copy link
Contributor

@jose-costa-frontify jose-costa-frontify commented Sep 4, 2024

CU-8695khnex

being unaware of any specific designs for scrollbars, I have used a slightly modified version of the OG radix styles

@jose-costa-frontify jose-costa-frontify requested a review from a team as a code owner September 4, 2024 18:42
Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: e636b0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@frontify/fondue-components Minor
@frontify/fondue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 4, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-05 12:32 UTC

@frontify-clickup-bot
Copy link
Collaborator

Task linked: CU-8695khnex Scrollbar component

Copy link
Member

@SamuelAlev SamuelAlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but small nit comment

@jose-costa-frontify jose-costa-frontify merged commit 29739b5 into main Sep 5, 2024
16 checks passed
@jose-costa-frontify jose-costa-frontify deleted the feat/add-scrollable-area branch September 5, 2024 12:32
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Lead time: 17 hours, 50 minutes, 48 seconds (17.85 total hours) from first commit to close.
Review time: 17 hours, 49 minutes, 54 seconds (17.83 total hours) from ready for review to close.

  • First commit: 4.9.2024, 20:41:21.
  • Ready for review: 4.9.2024, 20:42:15.
  • Closed: 5.9.2024, 14:32:09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants