Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): refactor component #2104

Merged
merged 41 commits into from
Nov 20, 2024
Merged

Conversation

jose-costa-frontify
Copy link
Contributor

@jose-costa-frontify jose-costa-frontify commented Nov 14, 2024

CU-8696na6d4

Definition of Done

  • User interface and experience have been verified by a designer
  • I have added thorough Cypress tests (All properties and interactions have been tested).
  • Cross-browser compatibility - The component look consistent in the latest version of Chrome, Safari, Firefox and Edge.
  • I've added documentation in Storybook. all properties are reflected in table and controls.
  • User interface is compliant with WCAG 2.1 AA. Ensure these items are fulfilled:
    • Keyboard operability: All functionality can be accessed using only the keyboard
    • Logical tab order: Interactive elements follow a consistent and logical tab order
    • Visual indication of focus: Focused elements are visually highlighted for keyboard navigation
    • Color contrast: Sufficient contrast is used between text and background, as well as form fields and background
    • Alternative visual cues: Information is not solely reliant on color and includes alternative visual indicators
    • Semantic markup: Headings, lists, and form elements are marked up with appropriate semantic tags

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: d0d5361

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@frontify/fondue-components Minor
@frontify/fondue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frontify-clickup-bot
Copy link
Collaborator

Task linked: CU-8696na6d4 Create new Table component

Copy link
Contributor

github-actions bot commented Nov 14, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-11-20 13:34 UTC

@jose-costa-frontify jose-costa-frontify marked this pull request as ready for review November 18, 2024 14:28
@jose-costa-frontify jose-costa-frontify requested a review from a team as a code owner November 18, 2024 14:28
@noahwaldner
Copy link
Contributor

Can we please add a shadow to the sticky first column when scrolled? that makes it clear that it's a "overlay"

@jose-costa-frontify jose-costa-frontify merged commit 153fa39 into main Nov 20, 2024
14 of 15 checks passed
@jose-costa-frontify jose-costa-frontify deleted the feat/add-table-component branch November 20, 2024 13:34
Copy link
Contributor

Lead time: 5 days, 23 hours, 10 minutes, 43 seconds (143.18 total hours) from first commit to close.
Review time: 1 days, 23 hours, 5 minutes, 58 seconds (47.10 total hours) from ready for review to close.

  • First commit: 14.11.2024, 15:23:29.
  • Ready for review: 18.11.2024, 15:28:14.
  • Closed: 20.11.2024, 14:34:12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants