Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): buttons within table cells are overflowing container #2143

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jose-costa-frontify
Copy link
Contributor

@jose-costa-frontify jose-costa-frontify commented Dec 16, 2024

CU-86971xjcy

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: fae9c46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@frontify/fondue-components Patch
@frontify/fondue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frontify-clickup-bot
Copy link
Collaborator

Copy link
Contributor

github-actions bot commented Dec 16, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-12-17 09:31 UTC

@noahwaldner
Copy link
Contributor

Code looks good, but does this actually fix the issue? how does box-sizing affect the overflowing?

@jose-costa-frontify
Copy link
Contributor Author

Code looks good, but does this actually fix the issue? how does box-sizing affect the overflowing?

I asked our good friend claude to give you a demonstration 😛

@jose-costa-frontify jose-costa-frontify merged commit 0068c39 into main Dec 17, 2024
16 checks passed
@jose-costa-frontify jose-costa-frontify deleted the fix/button-box-sizing branch December 17, 2024 09:31
Copy link
Contributor

Lead time: 19 hours, 7 minutes, 53 seconds (19.13 total hours) from first commit to close.
Review time: 19 hours, 7 minutes, 15 seconds (19.12 total hours) from ready for review to close.

  • First commit: 16.12.2024, 15:23:26.
  • Ready for review: 16.12.2024, 15:24:04.
  • Closed: 17.12.2024, 10:31:19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants