Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ColorPicker): allow empty alpha field #2162

Conversation

syeo66
Copy link
Contributor

@syeo66 syeo66 commented Jan 15, 2025

This way we can delete the field without immediately getting a '0'.

@syeo66 syeo66 requested a review from a team as a code owner January 15, 2025 12:03
@syeo66 syeo66 requested a review from noahwaldner January 15, 2025 12:03
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: e059119

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@frontify/fondue-components Patch
@frontify/fondue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frontify-clickup-bot
Copy link
Collaborator

Copy link
Contributor

github-actions bot commented Jan 15, 2025

PR Preview Action v1.5.0
Preview removed because the pull request was closed.
2025-01-15 13:20 UTC

…an-never-be-cleared-there-is-un-deleteable-0_Red-Ochsenbein
@syeo66 syeo66 self-assigned this Jan 15, 2025
@syeo66 syeo66 requested a review from SamuelAlev January 15, 2025 13:13
@syeo66 syeo66 enabled auto-merge (squash) January 15, 2025 13:16
@syeo66 syeo66 merged commit 010074e into main Jan 15, 2025
15 checks passed
@syeo66 syeo66 deleted the CU-86971x3zg_Color-picker-block-Alfa-input-can-never-be-cleared-there-is-un-deleteable-0_Red-Ochsenbein branch January 15, 2025 13:19
Copy link
Contributor

Lead time: 1 hours, 20 minutes, 3 seconds (1.33 total hours) from first commit to close.
Review time: 1 hours, 16 minutes, 46 seconds (1.28 total hours) from ready for review to close.

  • First commit: 15.1.2025, 12:59:47.
  • Ready for review: 15.1.2025, 13:03:04.
  • Closed: 15.1.2025, 14:19:50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants