Skip to content

Commit

Permalink
Merge pull request #816 from FrozenNode/dev
Browse files Browse the repository at this point in the history
Merging 4.16.4 into master
  • Loading branch information
janhartigan committed Feb 17, 2015
2 parents 86ea73d + 10d406d commit 550e51d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
3 changes: 3 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## Changelog

### 4.16.4
- Bugfix: Strange old bug when using only a setter field on a model

### 4.16.3
- Bugfix: Adding validateString back into Admin validator to avoid issues with old versions of Laravel

Expand Down
5 changes: 4 additions & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Administrator is an administrative interface builder for [Laravel](http://larave

- **Author:** Jan Hartigan
- **Website:** [http://frozennode.com](http://administrator.frozennode.com/)
- **Version:** 4.16.3
- **Version:** 4.16.4

[![Build Status](https://travis-ci.org/FrozenNode/Laravel-Administrator.png?branch=master)](https://travis-ci.org/FrozenNode/Laravel-Administrator)

Expand Down Expand Up @@ -53,6 +53,9 @@ Administrator is released under the MIT License. See the LICENSE file for detail

## Recent Changelog

### 4.16.4
- Bugfix: Strange old bug when using only a setter field on a model

### 4.16.3
- Bugfix: Adding validateString back into Admin validator to avoid issues with old versions of Laravel

Expand Down
2 changes: 1 addition & 1 deletion src/Frozennode/Administrator/Config/Model/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ public function fillModel(&$model, \Illuminate\Http\Request $input, array $field
$field->fillModel($model, $input->get($name, NULL));
}
//if this is an "external" field (i.e. it's not a column on this model's table) or uneditable, unset it
else
else if ($name !== $model->getKeyName())
{
$model->__unset($name);
}
Expand Down
1 change: 1 addition & 0 deletions tests/Config/Model/ModelConfigTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ public function testFillModel()
$model->field_setter = 'field_setter_value';
$model->field_password = '';
$model->shouldReceive('__unset')->times(4);
$model->shouldReceive('getKeyName')->times(2);
$fields = array(
'field_external' => $field_external,
'field_uneditable' => $field_uneditable,
Expand Down

0 comments on commit 550e51d

Please sign in to comment.