Without the public constructor, the class is effectively internal + @discardableResults + configuring queue #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migueldeicaza
changed the title
migueldeicaza
changed the title
|
@migueldeicaza I feel like using this PR / your fork is the "right thing to do" currently, until these changes are merged into master. Thanks for sharing it! |
|
Of course, you can feel free to use my branch. |
…dule' error I get when consuming the library
… secure enclave in SwiftTermApp
… rather than a formatted string
This enables for instance to start an SSH connection, and then use various channels over it. The SSHChannel no longer is a subclass of an SSHSession, which made things awkward when attempting to use the session again. Instead, the session is a field in the channel, and new channels can be constructed from the session if this is available. This also turns off the sample that defaulted to publicKey authentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings a constructor to the Environment class, without it, it is not possible to instantiate instances of it.
It also flags the various fluid-like APIs to be @discardableResults, to prevent errors from being raised when not using without a terminator.
Surfaces a way to configure the queue to be used for dispatching messages.