-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove validation for ts api docs #485
Conversation
We're looking to approach this migration in a phased approach, so we converted this to a draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petertonysmith94 not really sure how to do that. @FuelLabs/devrel any ideas? 👀 |
@petertonysmith94 @Dhaiwat10 I have included the link on the TS docs home page. We'd probably have to include it in the links json file but that'll probably break some kind of validation. IMO it should not block this work. |
@calldelegation @rishabhkeshan please let us know when you've had a chance to check this PR |
6dc982c
This reverts commit aa8c6e0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhaiwat10 we also need to remove the following line to ensure the automated versions doesn't check out our docs
branch.
2371e8a
This PR removes the validation in place for the TS SDK API docs since they have now been isolated in a different project on a different URL (FuelLabs/fuels-ts#3237) and they are now only referenced from the 'main' TS SDK docs.