Remove p2pservice networkcodec trait #2388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerone85
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
acerone85
changed the title
netrome
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Generally I like the decoupling you're achieving here. I think we could do some simplifications by reducing the number of traits, and for example just having one GossipSubCodec trait and oneRequestResponseReadWrite trait. Both of these could be generic over the data format if needed.
3 tasks
netrome
requested changes
Nov 25, 2024
| fn encode(&self, data: Self::RequestMessage) -> Result<Vec<u8>, io::Error> { | ||
| match data { | ||
| GossipsubBroadcastRequest::NewTx(tx) => { | ||
| Ok(self.codec.encode(&*tx)?.as_bytes().into_owned()) |
There was a problem hiding this comment.
Nit: The dereference is redundant here.
Suggested change
| Ok(self.codec.encode(&*tx)?.as_bytes().into_owned()) | |
| Ok(self.codec.encode(&tx)?.as_bytes().into_owned()) |
| { | ||
| let mut response = Vec::new(); | ||
| socket | ||
| .take(self.max_response_size as u64) |
There was a problem hiding this comment.
This as conversion can theoretically error. Personally I'd prefer to use u64::try_from explicitly instead, or as suggested before - redefine max_response_size as a u64.
There was a problem hiding this comment.
Same as above, see #2460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Closes #2368
Description
In the P2P service, we couple together GossipSub and RequestResponse codecs in a
NetworkCodectrait. In practice, this coupling is not necessary as the two codecs use different Messages and different logics for encoding/deconding messages. The only thing that they share in common is using Postcard as the data format to serialize and deserialize data, but this is not made clear in the network trait.This PR is a rework of Codecs in the libp2p service, which deletes the
NetworkCodectrait and therefore the coupling betweenGossipSubCodecandRequestResponseCodec. In particular:are moved to a structPostcardthat implements theDataFormat` trait,BoundedCodecstruct that implements theRequestResponse::Codectrait for anyDataFormatsupersedes the oldPostcardCodec.UnboundedCodecstruct that implements theGossipsubCodec trait for anyDataFormatsupersedes the oldPostcardCodec`,request_response::protocolsmodule`,GossipsubandRequestResponse.TODO:
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]