Ignore receipts from failed transactions in message_receipts_proof
#2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
xgreenx
reviewed
Dec 6, 2024
| @@ -278,7 +278,11 @@ fn message_receipts_proof<T: MessageProofData + ?Sized>( | |||
| // Get the message receipts from the block. | |||
| let leaves: Vec<Vec<Receipt>> = message_block_txs | |||
| .iter() | |||
| .map(|id| database.receipts(id)) | |||
There was a problem hiding this comment.
Maybe we also need to update another place with database.receipts function call. And remove receipts function at all=)
| database.insert_receipts(valid_tx_id, valid_tx_receipts.clone()); | ||
|
|
||
| // Get the message proof with the valid transaction | ||
| let message_proof_valid_tx = message_receipts_proof( |
There was a problem hiding this comment.
It would be nice if we tested public function message_proof instead of the private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2421
In this PR we changed the
message_receipts_proofto ignore the receipts from the failed transactions.Checklist
Before requesting review