This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1350.
Instead of overriding the Manifest file, this PR adds
--override-{start-block, end-block, identifier}
CLI options toforc-index {build, deploy}
, which allows us to achieve what we need for the QA script without touching the manifest file.It also looks like
forc index build
unnecessarily writes themodule
path to themanifest
:I think
forc-index
shouldn't modify the user's source files.Testing steps
CI tests should pass.
Changelog
write
method from theManifest
forc-index build
no longer overwrites the manifest file.