Refactoring to improve type safety #803
Draft
+427
−1,476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for #805 and possibly other changes, as this is quite aspiritional.
Work towards and enabled by #746.
Use type safe
RegId
instead ofRegisterId
which is justusize
. Get rid ofWriteRegKey
.This PR tries really hard to uphold full test and branch coverage while removing lots of test code. I'm hoping to split off some of the work to separate PRs to help with reviewing.
Checklist
Before requesting review