Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: encryp wallet with name(address) api. #1290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mtroym
Copy link

@mtroym mtroym commented Mar 3, 2024

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2024

CLA assistant check
All committers have signed the CLA.

@mtroym
Copy link
Author

mtroym commented Mar 3, 2024

hereby invite @digorithm @iqdecay @hal3e to review my pr. thanks.

@mtroym mtroym changed the title encryp wallet with name api. [feat] encryp wallet with name(address) api. Mar 3, 2024
@MujkicA MujkicA changed the title [feat] encryp wallet with name(address) api. feat: encryp wallet with name(address) api. Mar 13, 2024
@MujkicA
Copy link
Contributor

MujkicA commented Mar 13, 2024

I would suggest you move the name parameter to the existing encrypt method.
Also I would remove the test since it's just a wrapper for eth_keystore::encrypt_key

@mtroym
Copy link
Author

mtroym commented Mar 15, 2024

I would suggest you move the name parameter to the existing encrypt method. Also I would remove the test since it's just a wrapper for eth_keystore::encrypt_key

Great, will update later. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants