Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge std and core libraries #6729

Open
wants to merge 98 commits into
base: master
Choose a base branch
from
Open

Merge std and core libraries #6729

wants to merge 98 commits into from
+4,398 −6,659

Conversation

SwayStar123
Copy link
Collaborator

@SwayStar123 SwayStar123 commented Nov 18, 2024 •
edited
Loading

Description

Merges the two libraries. They were initially separate to separate the core logic and fuel vm specific functionality, but that separation is no longer maintained so having a merged library is better.

Closes #6708

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Sorry, something went wrong.

SwayStar123 and others added 26 commits November 18, 2024 12:23
@SwayStar123
move primitive_conversions
387e4ed
@SwayStar123
more raw_ptr
cb63d64
@SwayStar123
move codec
771081f
@SwayStar123
Merge branch 'master' into swaystar123/merge-core-std
129e18e
@SwayStar123
remove uses of core::codec in std lib
0d24485
@SwayStar123
add codec to lib.sw
29c1b40
@SwayStar123
change order of libs in lib.sw
6a14300
@SwayStar123
move slice, ops, primitves
f954429
@SwayStar123
move never and str, add core imports to prelude
24361d7
@SwayStar123
remove slice import - i tihnk unnecessary in ops
109c11b
@SwayStar123
add str to lib.sw
33ace1b
@SwayStar123
add r# to str
d4d42dc
@SwayStar123
remove original str impl
295bcb4
@SwayStar123
import AbiEncode where necessary
39cb0ed
@SwayStar123
add missing ;
e4d696c
@SwayStar123
remove log in import for flags.sw
2cad4ba
@SwayStar123
remove assert and error from flags import
06b2172
@SwayStar123
move out tests from ops lib
f5b1f1e
@SwayStar123
remove primitive conversions dependency from codec
140e97c
@SwayStar123
fix typo
928d527
@SwayStar123
fmt
7940ce2
@SwayStar123
progress
e809184
@SwayStar123
Merge branch 'master' into swaystar123/merge-core-std
30f1c93
@SwayStar123
remove todo stuff
f62e3f1
@SwayStar123
rid of all but 1 error
1bd6641
@SwayStar123
Merge branch 'master' into swaystar123/merge-core-std
4662ec9
@SwayStar123 SwayStar123 marked this pull request as ready for review March 10, 2025 07:22
@SwayStar123 SwayStar123 requested review from a team as code owners March 10, 2025 07:22
IGI-111
IGI-111 requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going through the PR and it looks fine so far but I want to block merging this until we have the migrations for it merged and released.

@ironcev ironcev added lib: std Standard library breaking May cause existing user code to break. Requires a minor or major release. labels Mar 10, 2025
@SwayStar123 SwayStar123 added compiler General compiler. Should eventually become more specific as the issue is triaged big this task is hard and will take a while lib: core Core library forc-pkg Everything related to the `forc-pkg` crate. labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xunilrj xunilrj

@IGI-111 IGI-111

Requested changes must be addressed to merge this pull request.

Assignees

@SwayStar123 SwayStar123

Labels
big this task is hard and will take a while breaking May cause existing user code to break. Requires a minor or major release. compiler General compiler. Should eventually become more specific as the issue is triaged forc-pkg Everything related to the `forc-pkg` crate. lib: core Core library lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine std-lib and core
6 participants
@SwayStar123 @xunilrj @IGI-111 @mchristopher @ironcev @sdankel