fix fallback compilation on new encoding #6998
Open
+21
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running tests in contracts with the fallback function, we get an error with the
__log
intrinsic. The issue is that we needlessly compile the fallback function twice. And in some cases (numeric decay), the__log
argument would return aTypeId
that was not collected in thecollect_metadata
phase.This was never caught because we only compile
sdk-harness
tests, we never run their unit tests in the CI. Which this PR is also doing.Checklist
Breaking*
orNew Feature
labels where relevant.