Redesign platform indicators on dispatch board #418
Conversation
Signed-off-by: Dan Griffiths <[email protected]>
Signed-off-by: Dan Griffiths <[email protected]>
| &.horizons3 > .platformBadgeLabel { | ||
| background-color: $magenta-dark3; | ||
| } | ||
|
|
||
| &.horizons4 { | ||
| &.horizons4 > .platformBadgeLabel { | ||
| background-color: $blue-dark3; | ||
| } | ||
|
|
||
| &.odyssey { | ||
| &.odyssey > .platformBadgeLabel { | ||
| background-color: $gold-dark2; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .platform { | ||
| &.ps { | ||
| color: $playstation-blue-light3 | ||
| } | ||
| &.ps > .platformBadgeLabel { | ||
| background-color: $xbox-green-light; | ||
| } | ||
|
|
||
| &.xb { | ||
| color: $xbox-green-light | ||
| } | ||
| &.xb > .platformBadgeLabel { | ||
| background-color: $playstation-blue-light3; | ||
| } |
There was a problem hiding this comment.
We should avoid useless hoisting of modifier classes like this. I'd say it would be better for these to exist as modifiers within the platformBadgeLabel class instead
Ideally we'd also try to keep our style structure within CSS modules as flat a possible, as they all complile to scoped CSS names anyway. There's no need to hold a definite element structure when the compiler assures all resulting class names will be unique. I believe this file is especially bad in that regard simply because it was faster to copy&paste the old stylesheet instead of recreating it for modules 😂. No need to do a big cleanup right now if you don't want to, but just wanted to call it out cuz it's easy to paint yourself into a corner by strictly defining your styles in this way.
There was a problem hiding this comment.
@evertiro this was left unaddressed 🙂
Signed-off-by: Dan Griffiths <[email protected]>
Signed-off-by: Dan Griffiths <[email protected]>
Signed-off-by: Dan Griffiths <[email protected]>
This reverts commit 56b23a4.
Signed-off-by: Dan Griffiths <[email protected]>
Rework platform indicators into a cleaner, simpler design. Note that there is a preexisting error with linting that has not been resolved due to the ps and xb classes being too short per our rules. Wasn't sure how to deal with this and since it's preexisting, I chose to leave it alone for now.
Fixes #413