Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: ResultState Accept Keybinds #3799

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JVNpixels
Copy link
Contributor

@JVNpixels JVNpixels commented Oct 28, 2024

Fix:

This PR allows users to press the accept keybinds when coming from the ResultsState, before you could only press the pause keybinds which I thought was strange, but I kept that in there just in case if there is a reason for it, and also allowing the player to press the accept keybinds as well.

Media:

Uhh, I made this just so that KreekCraft and his 8 year old audience don't freak out again (lol), along with saving other streamers. Sure, it doesn't get rid of the cartoon sex, but since people assume that space (which is usually an accept keybind set by default) is the way to close the menus, it will for sure help them right before the you know happens.

https://www.youtube.com/live/CeQQamE9kJs?si=y77S6iEvmtZN_mMA

@github-actions github-actions bot added pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. labels Oct 28, 2024
@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jan 17, 2025
@EliteMasterEric EliteMasterEric changed the base branch from main to develop January 17, 2025 01:01
@Hundrec Hundrec added the type: enhancement Involves an enhancement or new feature. label Jan 22, 2025
@AbnormalPoof
Copy link
Collaborator

This PR appears to have merge conflicts. Please fix them!

@AbnormalPoof AbnormalPoof added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Jan 22, 2025
@JVNpixels JVNpixels changed the base branch from develop to main January 22, 2025 22:15
@JVNpixels JVNpixels changed the base branch from main to develop January 22, 2025 22:15
@JVNpixels JVNpixels changed the base branch from develop to main January 22, 2025 22:15
@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Jan 22, 2025
@Lasercar
Copy link
Contributor

Lasercar commented Feb 12, 2025

Media:

Uhh, I made this just so that KreekCraft and his 8 year old audience don't freak out again (lol), along with saving other streamers. Sure, it doesn't get rid of the cartoon sex, but since people assume that space (which is usually an accept keybind set by default) is the way to close the menus, it will for sure help them right before the you know happens.

https://www.youtube.com/live/CeQQamE9kJs?si=y77S6iEvmtZN_mMA

Is there uh, already a suggestion to make a naughtiness enabled version of bf's 100% score? I'd check but I'm currently looking through all the PRs and finding linked issues that haven't been marked as having pending PRs.

(also this PR gave me a good laugh too, so there's that)

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Feb 12, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Feb 12, 2025

Actually, this PR should be based on develop

@JVNpixels JVNpixels changed the base branch from main to develop February 12, 2025 17:11
@JVNpixels
Copy link
Contributor Author

It is now based on develop.

@AbnormalPoof AbnormalPoof added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants