Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix early return in hasBeatenSong() #3820

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[BUGFIX] Fix early return in hasBeatenSong() #3820

merged 1 commit into from
Jan 17, 2025

Conversation

AbnormalPoof
Copy link
Collaborator

@AbnormalPoof AbnormalPoof commented Nov 1, 2024 •
edited
Loading

This PR fixes an early return in hasBeatenSong() and replaces it with continue; instead (since it's a for loop). There's already a return false; below the loop in the event that the song hasn't been beaten.

@github-actions github-actions bot added pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. labels Nov 1, 2024
@EliteMasterEric
Copy link
Member

Technically this only runs if there IS a score and the value is 0, but otherwise this looks correct.

@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. status: reviewing internally Under consideration and testing. labels Nov 1, 2024
@EliteMasterEric EliteMasterEric self-assigned this Nov 1, 2024
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Jan 17, 2025
@EliteMasterEric EliteMasterEric merged commit a3e2373 into FunkinCrew:develop Jan 17, 2025
6 checks passed
@EliteMasterEric EliteMasterEric added this to the 0.6.0 milestone Jan 17, 2025
@AbnormalPoof AbnormalPoof deleted the bugfix/has-beaten-song branch January 17, 2025 20:51
MidyGamy pushed a commit to MidyGamy/Funkin that referenced this pull request Jan 27, 2025
@AbnormalPoof @MidyGamy
fix early return in hasbeatensong and hasbeatenlevel (FunkinCrew#3820)
382b1fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.
2 participants
@AbnormalPoof @EliteMasterEric