Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pico and Tankman play animations in all difficulties #76

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hundrec
Copy link
Contributor

@Hundrec Hundrec commented Oct 6, 2024

Linked Issues

Fixes FunkinCrew/Funkin#3431
Fixes FunkinCrew/Funkin#3592

Description

In Ugh (Pico Mix) and Guns (Pico Mix) Easy and Normal, Pico's and Tankman's animations are cut off by notes present at the same time as the Play Animation events.

This PR:

  • Removes notes that overlap animations from the Easy and Normal charts
  • Subtly adjusts the position of a few animations to better match the timing of the audio

Additional Notes

To prevent this issue from happening in future charts, here's what I think happened:

  1. The charter originally charted all parts of the song including burps and voicelines
  2. Pico's animations were completed and implemented
  3. The charter added the animation events and removed notes from the Hard chart, but forgot to update the Normal and Easy charts

It is also important to note that note animations may override forced animations if they occur too close together (as seen in #74)

@EliteMasterEric EliteMasterEric added status: pending triage The bug or PR has not been reviewed yet. status: reviewing internally Cannot be approved; under continuing review and quality assurance testing type: charting issue Involves the charting or placement of notes for a level. and removed status: pending triage The bug or PR has not been reviewed yet. labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: reviewing internally Cannot be approved; under continuing review and quality assurance testing type: charting issue Involves the charting or placement of notes for a level.
Projects
None yet
2 participants