Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to upstream latest develop #3

Open
wants to merge 18 commits into
base: funkin-rebase
Choose a base branch
from

Conversation

ninjamuffin99
Copy link
Member

pretty much no merge conflicts, I merged this based off the state of funkin-rebase

important fixes for us here are:

  • openfl tracy support
  • fix for gradient on HTML5 (when doing screen wipe transition, it would have a weird hard cutoff...)

joshtynjala and others added 18 commits November 13, 2024 08:32
… versions

The hxp tests don't set up Application.current, which breaks ThreadPool. The hxp tests were always a pain to maintain anyway, so good riddance, in my opinion.
…nge in openfl#2658 broke certain gradients

Some gradients were not rendering correctly in Chrome or Safari (but worked in Firefox, interestingly) with OpenFL 9.4, but worked fine in OpenFL 9.3.

Keeping the new SpreadMethod implementations the same, though. They might have a similar issue, but I'm not familiar enough with how they work to test to see if it reproduces.

Relevant community thread where issue was reported: https://community.openfl.org/t/issues-after-upgrading-to-openfl-9-4-0-lime-8-2-0/14026
… intermittently and was using the default timeout of 250ms
…_scissorRect at extreme zoom levels. (openfl#2705)

* Delete Math.ceil and Math.floor for __ scissorRect.

In cases where the browser scaling ratio is very large, using Math.floor or Math.ceil will result in significant pixel errors, so it needs to be removed.

* Add uv offest.

* OpenGLRenderer: prefer ffloor() and fceil() over adding :Float type to variables

---------

Co-authored-by: Josh Tynjala <[email protected]>
@ninjamuffin99 ninjamuffin99 changed the base branch from develop to funkin-rebase November 20, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants