forked from openfl/openfl
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to upstream latest develop
#3
Open
ninjamuffin99
wants to merge
18
commits into
funkin-rebase
Choose a base branch
from
openfl-latest-develop
base: funkin-rebase
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versions The hxp tests don't set up Application.current, which breaks ThreadPool. The hxp tests were always a pain to maintain anyway, so good riddance, in my opinion.
… for macOS anymore" This reverts commit d863321.
This reverts commit c93b500.
…ll other versions" This reverts commit 76a9d3d.
…nge in openfl#2658 broke certain gradients Some gradients were not rendering correctly in Chrome or Safari (but worked in Firefox, interestingly) with OpenFL 9.4, but worked fine in OpenFL 9.3. Keeping the new SpreadMethod implementations the same, though. They might have a similar issue, but I'm not familiar enough with how they work to test to see if it reproduces. Relevant community thread where issue was reported: https://community.openfl.org/t/issues-after-upgrading-to-openfl-9-4-0-lime-8-2-0/14026
… intermittently and was using the default timeout of 250ms
…_scissorRect at extreme zoom levels. (openfl#2705) * Delete Math.ceil and Math.floor for __ scissorRect. In cases where the browser scaling ratio is very large, using Math.floor or Math.ceil will result in significant pixel errors, so it needs to be removed. * Add uv offest. * OpenGLRenderer: prefer ffloor() and fceil() over adding :Float type to variables --------- Co-authored-by: Josh Tynjala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pretty much no merge conflicts, I merged this based off the state of
funkin-rebase
important fixes for us here are: