Skip to content

Commit

Permalink
continuing
Browse files Browse the repository at this point in the history
  • Loading branch information
oliverfunk committed Oct 21, 2024
1 parent c1b3e4b commit 1d69601
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 10 deletions.
2 changes: 1 addition & 1 deletion bluemira/codes/process/equation_variable_mapping.py
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ class Constraint(ConstraintSelection, Model):
"fplhsep": 137,
"rebco_thickness": 138,
"copper_thick": 139,
"dr_tf_wp": 140, # TODO: WTF
"dr_tf_wp": 140,
"fcqt": 141,
"nesep": 142,
"f_coppera_m2": 143,
Expand Down
2 changes: 1 addition & 1 deletion bluemira/codes/process/mapping.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
"tk_ts": ("thshield_ib", "m"),
# "tk_ts": ("thshield_ob", "m"),
# "tk_ts": ("thshield_vb", "m"),
# TODO: q is not properly put in the MFILE output
# TODO @je-cook: q is not properly put in the MFILE output
# This should be ok OK most of the time as q_95 is input and then
# used as the lower bound of the q iteration variable, but this
# should be fixed as soon as PROCESS deal with this issue on
Expand Down
4 changes: 2 additions & 2 deletions bluemira/magnetostatics/biot_savart.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def _check_discretisation(d_l: npt.NDArray[np.float64]):
max_d_l = np.max(lengths)
if max_d_l > 0.03 * total:
bluemira_warn("Biot-Savart discretisation possibly insufficient.")
# TODO: Improve check and modify discretisation
# TODO @CoronelBuendia: Improve check and modify discretisation

@process_xyz_array
def potential(
Expand Down Expand Up @@ -202,7 +202,7 @@ def inductance(self) -> float:
You probably shouldn't use this if you are actually interested in the
inductance of an arbitrarily shaped Coordinates...
""" # noqa: W505, E501
# TODO: Validate inductance calculate properly and compare stored
# TODO @CoronelBuendia: Validate inductance calculate properly and compare stored
# energy of systems
inductance = 0
for _i, (x1, dx1) in enumerate(
Expand Down
2 changes: 1 addition & 1 deletion bluemira/magnetostatics/finite_element_2d.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def define_g(
dofs = locate_dofs_topological(self.V, tdim - 1, facets)
bcs = [dirichletbc(ScalarType(0), dofs, self.V)]
else:
# TODO: we should pass directly the BCs, not the functions since
# TODO @je-cook: we should pass directly the BCs, not the functions since
# dolfinx wants functions and dofs.
bcs = (
dirichlet_bc_function
Expand Down
4 changes: 2 additions & 2 deletions bluemira/materials/material.py
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ def __str__(self) -> str:
def __eq__(self, other: object) -> bool:
"""Equality Check"""
if not isinstance(other, type(self)):
# TODO a mixutre with only one component could be the same
# TODO @je-cook: a mixutre with only one component could be the same
return False
raise NotImplementedError("Material equality not implemented")

Expand Down Expand Up @@ -623,7 +623,7 @@ def Jc(self, B: float, temperature: float) -> float: # noqa: N802
# when raising a negative number to a fractional power, which in this
# parameterisation only occurs if a non-physical (<0) current density
# is returned.
# TODO: Check the above..
# TODO @DanShort12: Check the above..
c = (1 - ii) ** self.beta if 1 - ii > 0 else 0
return a * b * c

Expand Down
5 changes: 2 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,6 @@ ignore-names = [
"eudemo/eudemo/reactor.py" = ["ARG001"]
"bluemira/codes/plasmod/mapping.py" = ["TD"]
"bluemira/balance_of_plant/calculations.py" = ["TD"]
"bluemira/fuel_cycle/*" = ["TD"]
"{tests,eudemo/eudemo_tests}/*" = [
"INP001",
"PLR2004",
Expand Down Expand Up @@ -361,7 +360,7 @@ ignore-names = [
"tests/geometry/test_private_tools.py" = ["E501"]
"tests/utilities/test_opt_variables.py" = ["E501"]
# TODO remove
"eudemo/eudemo/*" = ["DOC201"] #186
"eudemo/eudemo/*" = ["DOC201", "TD"] #186
# see above for actual line
# "examples/*" = ["DOC201"] # 51
"bluemira/utilities/*" = ["DOC201"] # 38
Expand All @@ -373,7 +372,7 @@ ignore-names = [
"bluemira/materials/*" = ["DOC201"] # 62
"bluemira/magnetostatics/*" = ["DOC201"] # 45
"bluemira/geometry/*" = ["DOC201"] # 109
"bluemira/fuel_cycle/*" = ["DOC201"] # 19
"bluemira/fuel_cycle/*" = ["DOC201", "TD"] # 19
"bluemira/equilibria/*" = ["DOC201"] # 217
"bluemira/display/*" = ["DOC201"] # 25
"bluemira/codes/*" = ["DOC201"] # 242
Expand Down

0 comments on commit 1d69601

Please sign in to comment.