Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix units and unit-conversion factors #2891

Merged
merged 9 commits into from
Jun 4, 2024
Merged

Fix units and unit-conversion factors #2891

merged 9 commits into from
Jun 4, 2024

Commits on Dec 19, 2023

  1. Removed redundant units

    @OceanNuclear
    OceanNuclear committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    1111a55 View commit details
    Browse the repository at this point in the history

  2. Removed all 'years' variable and YR_TO_S variables. Found two possibl… 

    …e errors.
    @OceanNuclear
    OceanNuclear committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e911242 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Made units more understandable

    @OceanNuclear
    OceanNuclear committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c5c1c5b View commit details
    Browse the repository at this point in the history

  2. Undid all the raw_uc conversions in tools.py as they are not compatib… 

    …le with numba.jit's optimization. Using the constants YR_TO_S and S_TO_YR.
    @OceanNuclear
    OceanNuclear committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c8250b7 View commit details
    Browse the repository at this point in the history

  3. Removed as many S_TO_YR and YR_TO_S as possible.

    @OceanNuclear
    OceanNuclear committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    7e33c93 View commit details
    Browse the repository at this point in the history

  4. Fixed the problem of missing elementary charge (e) constant in base.c… 

    …onstants
    @OceanNuclear
    OceanNuclear committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1a9a34e View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Undid all S_TO_YR/YR_TO_S changes

    @OceanNuclear
    OceanNuclear committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c8a1a24 View commit details
    Browse the repository at this point in the history

  2. Minor fixes to the YR_TO_S

    @OceanNuclear
    OceanNuclear committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c1c9ba4 View commit details
    Browse the repository at this point in the history

  3. Added back in C_LIGHT

    @OceanNuclear
    OceanNuclear committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c17dd4a View commit details
    Browse the repository at this point in the history