Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ FreeCAD v1 #3304

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from
Draft

⬆️ FreeCAD v1 #3304

wants to merge 29 commits into from

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented May 29, 2024 •
edited
Loading

Linked Issues

Hopefully but needs checking
closes #1347
closes #513
closes #3236

Description

  • Updates FreeCAD to the weekly as they come towards releasing V1.
  • Removes XPASSing test marking.
  • Adds reasons for some of those still failing
  • Fixes some different CAD exports (inc webgl which is quite useful)
  • Adds the ability to import CAD files

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added cad Tasks relating to the cad module dependencies Pull requests that update a dependency file labels May 29, 2024
@codecov Codecov
Copy link

codecov bot commented May 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.08213% with 64 lines in your changes missing coverage. Please review.

Project coverage is 76.56%. Comparing base (02b9bf1) to head (2e465e0).

Files with missing lines Patch % Lines
bluemira/codes/_freecadapi.py 67.19% 62 Missing ⚠️
bluemira/geometry/tools.py 80.00% 1 Missing ⚠️
bluemira/geometry/wire.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3304      +/-   ##
===========================================
+ Coverage    76.53%   76.56%   +0.02%     
===========================================
  Files          230      230              
  Lines        26834    26984     +150     
===========================================
+ Hits         20538    20660     +122     
- Misses        6296     6324      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@je-cook je-cook force-pushed the je-cook/freecad_v1 branch 2 times, most recently from 2f3beb9 to 06015d8 Compare June 10, 2024 08:27
@je-cook
Copy link
Contributor Author

je-cook commented Jun 12, 2024 •
edited
Loading

importing needs to be scaled because we save in mm but the default internally is in m done

@je-cook je-cook force-pushed the je-cook/freecad_v1 branch 2 times, most recently from c6d2c18 to 429ecbe Compare June 28, 2024 14:46
@je-cook je-cook force-pushed the je-cook/freecad_v1 branch 2 times, most recently from 054e6d8 to ec95702 Compare July 9, 2024 08:17
@je-cook je-cook force-pushed the je-cook/freecad_v1 branch 2 times, most recently from f098849 to ed4831a Compare August 14, 2024 12:38
@je-cook je-cook force-pushed the je-cook/freecad_v1 branch 2 times, most recently from 797845d to a3ab10a Compare August 29, 2024 09:22
@je-cook je-cook mentioned this pull request Oct 4, 2024
Open
@je-cook je-cook force-pushed the je-cook/freecad_v1 branch 2 times, most recently from e485e2c to 6e85da9 Compare October 21, 2024 15:26
This was linked to issues Oct 22, 2024
Some of these crash on CI (?) #3668
Open
Investigate this princetonD parameterisation #3672
Open
@je-cook je-cook force-pushed the je-cook/freecad_v1 branch 2 times, most recently from 872e354 to 405981b Compare October 23, 2024 07:13
@je-cook je-cook force-pushed the je-cook/freecad_v1 branch 2 times, most recently from 843995c to e089f59 Compare November 7, 2024 10:30
je-cook and others added 23 commits November 20, 2024 13:13
@je-cook
🎨 Document context manager to keep track of open docs
254b732
@je-cook
🐛 Improve document context manager
ff57c80
@je-cook
✨ Importing CAD files
2e84936
@je-cook
🐛 Fix import scale
3e88176
@je-cook
✅ Shell imort
e4afa6a
@je-cook
🎨 Minor cleanup
e5d8755
@je-cook
✅ Remove hack to make test pass (freecad fixed it)
804f427
@je-cook
🚨 Ruff fixes
b6b28b1
@je-cook
⬆️ First release candidate
1c35e8c
@je-cook
🐛 Catch floating point lessthan
838b48b
@je-cook
⬆️ Second release candidate
96d498e
@je-cook
✨ Improve lighting of viewer
ff249fc
@je-cook
✨ Rotate camera not object
6c31203
@je-cook
🐛 Fix rotation and improve headlight
509d0ac
@je-cook
📝 Spelling
4d95d15
@je-cook
✨ Add missing for CADFiletype
d72fcbd
@je-cook
🚨 Initial fix todo
5e15ae5
@je-cook
⬆️ Version fixes
5cddccb
@je-cook
✅ Parameterise tests properly
c8ea9cd
@je-cook
🐛 Fix save cad unit
a48ed9f
@je-cook
🐛 Patch for tolerance of faces
cb3cd6d
@je-cook
🚨 Linter updates
8e2d970
@je-cook
🎨 A few cleanups
1305ee0
@je-cook
Revert "🐛 Fix save cad unit"
2e465e0 
This reverts commit a48ed9f.
Apparently this is post V1...
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This was referenced Nov 22, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cad Tasks relating to the cad module dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
1 participant
@je-cook