-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toroidal harmonic notebooks #3645
Toroidal harmonic notebooks #3645
Conversation
…rdinates and necessary tests
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/toroidal-harmonics #3645 +/- ##
==============================================================
+ Coverage 74.64% 75.96% +1.31%
==============================================================
Files 231 231
Lines 26871 26749 -122
==============================================================
+ Hits 20058 20320 +262
+ Misses 6813 6429 -384 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a discussion with @clmould - will move comments across to the new branch PR and continue review on new PR.
from scipy.special import gamma, poch | ||
|
||
|
||
def f_hypergeometric(a, b, c, z, n_max): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have some tests for these new functions?
|
||
|
||
def my_legendre_q(lam, mu, x, n_max=20): | ||
"""Evaluates Olver's associated Legendre function of the second kind of degree lambda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oliver is missing an 'i' and should probably use his surname as well, and briefly explain function choice.
This branch is outdated so closing this PR as an updated one has been made #3681 |
Linked Issues
Closes #{ID}
Description
Interface Changes
Checklist
I confirm that I have completed the following checks:
pytest tests --reactor
pre-commit run --from-ref develop --to-ref HEAD
sphinx-build -W documentation/source documentation/build
📚 Documentation preview 📚: https://bluemira--3645.org.readthedocs.build/en/3645/