Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding toroidal harmonic notebooks #3681
base: feature/toroidal-harmonics
Are you sure you want to change the base?
Adding toroidal harmonic notebooks #3681
Changes from all commits
f9e0dd3
27871cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 11 in bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py
Codecov / codecov/patch
bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py#L11
Check warning on line 14 in bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py
Codecov / codecov/patch
bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py#L13-L14
Check warning on line 17 in bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py
Codecov / codecov/patch
bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py#L17
Check warning on line 29 in bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py
Codecov / codecov/patch
bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py#L26-L29
Check warning on line 32 in bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py
Codecov / codecov/patch
bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py#L32
Check warning on line 52 in bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py
Codecov / codecov/patch
bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py#L46-L52
Check warning on line 55 in bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py
Codecov / codecov/patch
bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py#L55
Check warning on line 76 in bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py
Codecov / codecov/patch
bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py#L71-L76
Check warning on line 83 in bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py
Codecov / codecov/patch
bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py#L81-L83
Check warning on line 86 in bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py
Codecov / codecov/patch
bluemira/equilibria/optimisation/harmonics/toroidal_harmonics_approx_functions.py#L85-L86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have written up the markdown equations in the order you use them, however, it might be a bit clearer if you introduce us to the TH equations at the start of the notebook so the reader understands what you are aiming for, before breaking it down into the calculation steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add a brief note hear about order and degree