Papercut 3666 #3814
Closed
Papercut 3666 #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🎨 Small cleanup * 🚧 Initial structure
* Create equilibrium comparison plotter class - compare equilibrium object with reference equilibrium - split psi plotting - plotting percentage difference between current and reference equilibrium - plot reference lcfs * work on plots before work to update plot instead of producing new plots * make subplots have the same axes limits * remove unused argument in call to EquilibriumComparisonPlotter class in _minimal_current * Add xz_plot_setup to plot_tools.py * working on updating plot * remove blank line after docstring * trying to update colorbar (from stackexchange) * colorbar updating instead of multiple colorbars * add # noqa: BLE001 to Exception * update typing * pre-commit changes * fix from github comment * 🚨 Few missing imports --------- Co-authored-by: james <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
Co-authored-by: je-cook <[email protected]>
geograham
force-pushed
the
papercut_3666
branch
from
cd5f3bb to
8176612
Compare
|
|
Wrong branch. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3814 +/- ##
===========================================
- Coverage 76.75% 76.63% -0.13%
===========================================
Files 230 232 +2
Lines 27238 28187 +949
===========================================
+ Hits 20906 21600 +694
- Misses 6332 6587 +255 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closed papercut #3666
Description
"Why does the less intuitive, simpler algebra form work better??"
Not certain of the answer, but as we have the safe _direction_cosine_matrix_debugging version to compare to the speedier _direction_cosine_matrix, it seems ok to remove it from papercut TODO's.
Have left as a NOTE in comments.
Checklist
I confirm that I have completed the following checks:
pytest tests --reactorpre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build