Make vale work

[mooreds]

• made vale fail on error
• fixed a ton of misspellings or incorrect casing
• wrote ignore clauses for some more cases
• updated dev docs to reflect new vale work
• fixed incorrect example apps count

[lyleschemmerling]

how were you testing the updates? Just letting the github action run on commit, or are you running this locally?

[mooreds]

Running locally. Per devdocsreadme, you can run with vale --config .vale.ini astro/src/content or a more narrowly focused path. That is if you have installed vale locally, which I have. I think there's also a way to run it via docker if you don't want to install it.

[mooreds]

I plan to ask @synedra to review it tomorrow morning first, then ask for your blessing @lyleschemmerling , because of the GH action change (which is minor).

[LucasPMorris]

Replying from email, not GH or whatever. In a restaurant in HA and this raised some questions in my head so replying via the avenue in front of me. What was the intent of adding support as a reviewer? With 100+ file changes I don't think anyone in support can properly review (and appropriately approve) these changes.

…

On Tue, Sep 10, 2024, 6:01 PM Dan Moore ***@***.***> wrote: Running locally. Per devdocsreadme, you can run with vale --config .vale.ini astro/src/content or a more narrowly focused path. That is if you have installed vale locally, which I have. I think there's also a way to run it via docker if you don't want to install it. — Reply to this email directly, view it on GitHub <#3261 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BC72CFCVEFZPAJMIS6K2DMTZV66CTAVCNFSM6AAAAABOABHPH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBSGU3TEOBXG4> . You are receiving this because your review was requested.Message ID: ***@***.***>

[mooreds]

@LucasPMorris go back to your vacation! :)

Seriously, I didn't pick the reviewers; it happens automatically. It happens because of a change to codeowners ( d347d1a ).

I don't know what drove that change, wasn't involved.

[LucasPMorris]

Haha, okay, going back on vacation. I just didn't want someone on the support team to either 1) give blanket approval for a significant change or 2) become immediately overwhelmed with reviewing 100+ file changes. Thanks, Luke

…

On Tue, Sep 10, 2024, 6:11 PM Dan Moore ***@***.***> wrote: @LucasPMorris <https://github.com/LucasPMorris> go back to your vacation! :) Seriously, I didn't pick the reviewers; it happens automatically. It happens because of a change to codeowners ( d347d1a <d347d1a> ). I don't know what drove that change, wasn't involved. — Reply to this email directly, view it on GitHub <#3261 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BC72CFFZIRCLBHNEEP5Y5JLZV67HFAVCNFSM6AAAAABOABHPH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBSGU4DCNZWGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[synedra]

It's clear and I'm excited to have a new tool to make our content more consistent!