Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Secure and monitor restructure #3280

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: Secure and monitor restructure #3280

wants to merge 3 commits into from

Conversation

sixhobbits
Copy link
Collaborator

No description provided.

@sixhobbits sixhobbits requested review from a team as code owners September 18, 2024 13:15
@alex-fusionauth
Copy link
Contributor

@sixhobbits please resolve conflicts.

synedra
synedra reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@synedra synedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you updated the redirects.json, which is good, but that will only point refs from the Before Time to the new pages, there will also need to be redirects for /secure-and-monitor to /monitor and such

@rideam
Merge branch 'main' into secure-and-monitor-restructure
8783433 
# Conflicts:
#	astro/src/content/json/features.json
@rideam rideam requested a review from a team as a code owner November 1, 2024 06:59
@sixhobbits
Copy link
Collaborator Author

@synedra sorry for the delay - could you clarify what still needs to be done. We do have redirects set up from the secure-and-monitor URLs to the new structure in that same file:

image

@bradmccarty
Copy link
Contributor

@mark-robustelli please see the above discussion and review.

@mark-robustelli
Copy link
Contributor

@synedra It looks to me like the redirects should work. Are we OK to approve this or am I missing something?

synedra
synedra approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@synedra synedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synedra synedra synedra approved these changes

@tonyblank tonyblank Awaiting requested review from tonyblank

Assignees

@bradmccarty bradmccarty

@mark-robustelli mark-robustelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sixhobbits @alex-fusionauth @bradmccarty @mark-robustelli @synedra @rideam